gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.h:32 +// }; +class TransformerTidy : public ClangTidyCheck { +public: ---------------- I'd prefer a name like "TransformerClangTidyCheck", it will only appear in a few places, but is much more clear. ================ Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.h:38 + + void registerMatchers(ast_matchers::MatchFinder *Finder) override; + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; ---------------- I'd suggest to add comments telling users to not override these methods in subclasses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits