a_sidorin added a comment.
Hi Artem,
Looks mostly good, but I have some comments inline.
================
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1064
// e.g. "{a, b}" represent the qualified names, like "a::b".
std::vector<const char *> QualifiedName;
unsigned RequiredArgs;
----------------
Not for this review, but why do we have a vector of `const char *`, not
StringRefs?
================
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1066
unsigned RequiredArgs;
+ int Flags;
----------------
Is it a good idea to make Flags a bitfield structure?
================
Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:379
+
if (!II || II != CD.II)
return false;
----------------
`!II` is never false due to the newly-introduced early return.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62556/new/
https://reviews.llvm.org/D62556
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
