Anastasia added inline comments. ================ Comment at: lib/Sema/SemaChecking.cpp:294 @@ +293,3 @@ + diag::err_opencl_builtin_pipe_invalid_access_modifier) + << "read_only" << Arg0->getSourceRange(); + return true; ---------------- Anastasia wrote: > Could we use getName() instead? > > We could then also move this statement after the switch and just set an error > flag here. Just to be clear getName() of the attr instead of passing the string (i.e. "read_only").
http://reviews.llvm.org/D16876 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
