Szelethus marked an inline comment as done. Szelethus added a comment. I usually do the final update right before commiting. There still are non-accepted dependencies, who knows what'll happen.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:157 + /// Conditions we're already tracking. + llvm::SmallPtrSet<const Expr *, 4> TrackedConditions; + ---------------- xazax.hun wrote: > Szelethus wrote: > > xazax.hun wrote: > > > Do we need this? I wonder if marking the result of the condition as > > > interesting is sufficient. > > Later on, when I'm covering the "should-not-have-happened" case, it's > > possible that a condition would be added that wasn't even explored by the > > analyzer, so this is kinda necessary. > When the analyzer did not explore a given code snippet we will not have an > exploded node, but we can change this in a followup patch. Ugh, right. Let's keep this as is is for now, dunno how I forgot about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
