Bigcheese accepted this revision. Bigcheese added inline comments.
================ Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:270 + return false; + if (Prev == '8' && (Cur - 1 != Start) && *(Cur - 2) == 'u') + return false; ---------------- arphaman wrote: > Bigcheese wrote: > > Are we sure at this point that it's always safe to jump back 2? > It should be, because otherwise `Start` would've been equals to `Cur - 1` > which we check for right before the dereference. Oh, obviously. I missed that check. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64525/new/ https://reviews.llvm.org/D64525 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
