NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks great to me once @Szelethus's comments are addressed. Thanks!!
================
Comment at: lib/StaticAnalyzer/Checkers/Yaml.h:34
+ std::string(ConfigFile) + "'");
+ return {};
+ }
----------------
I suggest `None` for being more explicit and readable.
================
Comment at: test/Analysis/taint-generic.c:24
+// CHECK-INVALID-FILE-SAME:
'alpha.security.taint.TaintPropagation:Config',
+// CHECK-INVALID-FILE-SAME: that expects a valid filename
----------------
Szelethus wrote:
> Could you please add the rest of the error message?
I'd rather remove the rest of the error message. There's no need to duplicate
something that the user has already written on the command line.
Or do we think like \escapes?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59555/new/
https://reviews.llvm.org/D59555
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
