ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:307
+ llvm::StringRef NewCode;
+ std::vector<int> DiffedLines;
+ } TestCases[]{
----------------
@hokein rightfully pointed out that mentioning all changed lines makes the
tests unreadable.
An alternative idea we all came up with is to force people to put `^` on each
of the changed lines inside the `NewCode`, i.e.
```
{/*Before*/ R"(
$Var[[a]]
$Func[[b]]
"),
/*After*/ R"(
$Var[[a]]
^$Func[[b]]
)"} // and no list of lines is needed!
```
Could we do that here?
One interesting case that we can't test this way to removing lines from the end
of the file. But for that particular case, could we just write a separate test
case?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64475/new/
https://reviews.llvm.org/D64475
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
