SureYeaah accepted this revision. SureYeaah added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang-tools-extra/clangd/SourceCode.cpp:284 + return SM.getComposedLoc(IncludingFile, Offset); + if (Buf[Offset] == '\n' || Offset == 0) // no hash, what's going on? + return SourceLocation(); ---------------- nit: use this as a while condition? ``` while(Offset-- && Buf[Offset] != '\n') ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66590/new/ https://reviews.llvm.org/D66590 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
