[PATCH] D66705: FileManager: Use llvm::Expected in new getFileRef API

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added inline comments.


================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1079
   if (!File) {
     // Check ".../Frameworks/HIToolbox.framework/PrivateHeaders/HIToolbox.h"
     HeadersFilename = FrameworkName;
----------------
It should be fine to update the return type, but I believe that `Expected` will 
cause an assertion as the error is unhandled in cases like this one. Can you 
verify that all errors are consumed somehow?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66705/new/

https://reviews.llvm.org/D66705



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits