NoQ added a comment.
Mmm, i don't know what was that commit meant to fix. Your evaluation looks
fairly sufficient for turning it on by default. Let's make it an on-by-default
option and flip the flag back into off-by-default if it turns out to be somehow
broken.
================
Comment at: clang/docs/analyzer/checkers.rst:299
+
+This checker has several options which can be set from command line (e.g.
+``-analyzer-config deadcode.DeadStores:WarnForDeadNestedAssignments=true``):
----------------
several?
================
Comment at: clang/test/Analysis/dead-stores.c:81
extern int *baz();
+#ifdef WARN_FOR_DEAD_NESTED
+ if ((p = baz())) // expected-warning{{Although the value stored}}
----------------
Pls consider `-verify=...` for new tests (cf. D60732).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66733/new/
https://reviews.llvm.org/D66733
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
