dnsampaio accepted this revision.
dnsampaio added a comment.
This revision is now accepted and ready to land.
LGTM. One optional nit as it is not related with this patch anymore.
================
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:659
llvm::ARM::ArchKind ArchKind;
- if (CPU == "generic") {
+ if (CPU == "generic" || CPU.empty()) {
std::string ARMArch = tools::arm::getARMArch(Arch, Triple);
----------------
dnsampaio wrote:
> Good catch.
For safety perhaps we can keep the CPU.empty() test.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66018/new/
https://reviews.llvm.org/D66018
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
