[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri resigned from this revision.
lebedev.ri added a comment.

Looks about right now, thanks for unbreaking it.



================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:5419-5420
   //   b relational-op var
   //
   if (!S) {
+               SemaRef.Diag(DefaultLoc, diag::err_omp_loop_not_canonical_cond)
----------------
It may be much cleaner to
```
bool IneqCondIsCanonical = SemaRef.getLangOpts().OpenMP >= 50;
```
and use that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66559/new/

https://reviews.llvm.org/D66559



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits