SouraVX marked 2 inline comments as done.
SouraVX added a comment.
In D68117#1686235 <https://reviews.llvm.org/D68117#1686235>, @aprantl wrote:
> This needs a lot more test coverage: The frontend cases aren't all covered by
> frontend checks and neither is the dwarf output.
Do you mean to add more test cases ? Could you please elaborate on this?
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1608
+ if (CGM.getCodeGenOpts().DwarfVersion >= 5) {
+ // DWARF-5 support for, defaulted, deleted member functions
----------------
aprantl wrote:
> Please try to always upload patches with more context (git diff -U9999 works
> fine). I can't even tell which function this is in otherwise.
Thanks, for correcting this. Seems to miss context part every time.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68117/new/
https://reviews.llvm.org/D68117
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
