SouraVX marked 3 inline comments as done.
SouraVX added inline comments.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1619
+ else {
+ SPFlags |= llvm::DISubprogram::SPFlagNotDefaulted;
+ }
----------------
Previously SPFlagNotDefaulted is setted to SPFlagZero as it's normal value is,
to save a bit. Hence in generated IR this flag is not getting set. instead 0 is
getting emitted.
As a result, test cases checking DISPFlagNotDefaulted in IR are failing.
================
Comment at: clang/test/CodeGenCXX/debug-info-not-defaulted.cpp:9
+
+// ATTR: DISubprogram(name: "not_defaulted", {{.*}}, flags: DIFlagPublic |
DIFlagPrototyped, spFlags: DISPFlagNotDefaulted
+// ATTR: DISubprogram(name: "not_defaulted", {{.*}}, flags: DIFlagPublic |
DIFlagPrototyped, spFlags: DISPFlagNotDefaulted
----------------
This test case is failing, checking DISPFlagNotDefaulted.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68117/new/
https://reviews.llvm.org/D68117
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
