SouraVX marked 2 inline comments as done.
SouraVX added inline comments.
================
Comment at: clang/test/CodeGenCXX/debug-info-defaulted-out-of-class.cpp:25
+
+ //FIXME -- clang will not mark above member funtions, excluding constructors
+ // as out of class. If we did not mark destructor or other member functions
----------------
This is the case, checking for Out of class definition. I've been mentioning in
llvm-dev mails.
================
Comment at: clang/test/CodeGenCXX/debug-info-not-defaulted.cpp:9
+
+// ATTR: DISubprogram(name: "not_defaulted", {{.*}}, flags: DIFlagPublic |
DIFlagPrototyped, spFlags: DISPFlagNotDefaulted
+// ATTR: DISubprogram(name: "not_defaulted", {{.*}}, flags: DIFlagPublic |
DIFlagPrototyped, spFlags: DISPFlagNotDefaulted
----------------
SouraVX wrote:
> This test case is failing, checking DISPFlagNotDefaulted.
Please note here that, backend and llvm-dwarfdump is fine without this.
Since it's value is '0' , we are able to query this using isNotDefaulted() --
hence attribute
DW_AT_defaulted having value DW_DEFAULTED_no is getting set and emitted and
dumped fine by llvm-dwarfdump.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68117/new/
https://reviews.llvm.org/D68117
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
