sunfish marked an inline comment as done.
sunfish added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96
+ if (Arg *A = Args.getLastArg(options::OPT_O_Group)) {
+ if (const char *WasmOptPath = getenv("WASM_OPT")) {
+ StringRef OOpt = "s";
----------------
dschuff wrote:
> What would you think about adding a way to pass arguments through to wasm-opt
> on the command line, like we have for the linker, assembler, etc? Something
> like `-Wo,-O2` (or `-Ww` or whatever; analogous to `-Wl` and `-Wa`). That
> seems nicer than an env var, although it doesn't solve the problem of
> controlling whether to run the optimizer in the first place.
My guess here is that we don't need clang to have an option for passing
additional flags -- if people want to do extra special things with wasm-opt on
clang's output they can just run wasm-opt directly themselves. Does that sound
reasonable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70500/new/
https://reviews.llvm.org/D70500
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
