serge-sans-paille marked 9 inline comments as done. serge-sans-paille added inline comments.
================ Comment at: clang/lib/CodeGen/CGStmt.cpp:2254 + CGM.getDiags().Report(S.getAsmLoc(), + diag::warn_fe_stack_clash_protection_inline_asm); + } ---------------- craig.topper wrote: > Why is this in the frontend diagnostic list? As far as I understand, that's the only place where line/col accurate diagnostics are emitted. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2575 + default: + return; + case llvm::Triple::ArchType::x86: ---------------- tstellar wrote: > Do we need to warn (or error) here for arches that don't implement > -fstack-clash-protection? That's done indirectly because the argument is not claimed on unsupported platform. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
