hubert.reinterpretcast added inline comments.
================
Comment at: llvm/include/llvm/Support/FileUtilities.h:44
+ if (!FuncAddr) {
+ return "";
+ }
----------------
I'm not sure that this function should handle failure by returning an empty
string. The error condition can be made explicit by making the return type of
the function `llvm::Expected<SmallString<128>>`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72736/new/
https://reviews.llvm.org/D72736
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
