mibintc marked 2 inline comments as done.
mibintc added a comment.
Added inline reply
================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:111
// the corresponding enum in the IR.
-static llvm::fp::RoundingMode ToConstrainedRoundingMD(
+llvm::fp::RoundingMode clang::ToConstrainedRoundingMD(
LangOptions::FPRoundingModeKind Kind) {
----------------
sepavloff wrote:
> Is `clang::` necessary here? The file already has `using namespace clang;`.
Yes the clang:: is necessary here, without it there are undefined symbols at
link time. the using modifies name lookup but not declaration.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72841/new/
https://reviews.llvm.org/D72841
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
