Szelethus added a reviewer: boga95.
Szelethus added a comment.
In D74131#1884372 <https://reviews.llvm.org/D74131#1884372>, @steakhal wrote:
> If this patch is good to go, could someone commit it?
> I don't have commit access (yet).
I think you can apply for a commit access, you have a history of high quality
patches!
================
Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:97
.Case("clang_analyzer_express", &ExprInspectionChecker::analyzerExpress)
+ .StartsWith("clang_analyzer_isTainted",
&ExprInspectionChecker::analyzerIsTainted)
.Default(nullptr);
----------------
xazax.hun wrote:
> I think a comment somewhere why/when do we check only the prefix would be
> useful.
This isn't done?
================
Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:427-430
+ if (CE->getNumArgs() != 1) {
+ reportBug("clang_analyzer_isTainted() requires exactly one argument", C);
+ return;
+ }
----------------
Might as well create a test case for this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74131/new/
https://reviews.llvm.org/D74131
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
