steakhal added a comment. In D71524#1889566 <https://reviews.llvm.org/D71524#1889566>, @boga95 wrote:
> @steakhal's revision is on the top of this. Changing the order will only > cause unnecessary work on both sides. I would happily rebase this patch if you want. ================ Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:139 + /// Add taint sources for extraction operator on pre-visit. + bool addOverloadedOpPre(const CallExpr *CE, CheckerContext &C) const; ---------------- boga95 wrote: > Szelethus wrote: > > Extraction operator? Is that a thing? > I can call it `operator>>` if you think that is better. I think `extraction operator` is the right term for this. It is used in the standard: http://eel.is/c++draft/input.streams#istream.extractors ================ Comment at: clang/test/Analysis/taint-generic.cpp:189 + istream& getline(istream& is, string& str); +} + ---------------- balazske wrote: > These `std` declarations are at a better place in > `system-header-simulator-cxx.h` or a similar file. In the current form, it seems to be a bit verbose. Why don't we create a minimal `std::string` which does not inherit from anything and implements the features and behavior only what is necessary. After minimizing this class there would be no benefit moving to the `system-header-simulator-cxx.h` header. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/ https://reviews.llvm.org/D71524 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
