Szelethus added a comment. In D75682#1931108 <https://reviews.llvm.org/D75682#1931108>, @balazske wrote:
> Adding special test functions is not as easy, then `StreamState` should be > accessible from another checker. It could be added to the same file, or new > file but then moving the data structures into header is needed. For the time being, I don't fancy the idea of moving code to a header file. > At least for short-term it is more simple to add a stream function that > generates error state (`fseek` is applicable or other). This is why the > `fseek` patch is better to be included in this change (but makes it more > complicated). Otherwise this revision must be added without tests for state > observer functions. It seems like D75356 <https://reviews.llvm.org/D75356> should have been the revision to finish, after all :^). I agree -- don't worry about bloating the patch a bit, I've spend a lot of time with your patches, I feel confident in my ability at this point to be able to thoroughly review it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
