hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
In D76595#1938727 <https://reviews.llvm.org/D76595#1938727>, @kbobyrev wrote: > In D76595#1936408 <https://reviews.llvm.org/D76595#1936408>, @hokein wrote: > > > thanks. regarding files in `.vscode`, I think they are just local configs > > in VSCode, we can probably remove the whole directory from git since we > > already ignore them in the `llvm/.gitignore`. > > > I think those are hand-written VSCode tasks and removing those would result > in the absence of compiling and debugging actions in VSCode. > `llvm/.gitignore` is intended to ignore the configs, but I'm not sure it is a > "config file" in traditional sensee. Am I missing something? ah, I see. If removing these would cause troubles, then let's keep it (I thought these files are generated by VSCode as well). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76595/new/ https://reviews.llvm.org/D76595 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
