Quuxplusone marked 2 inline comments as done.
Quuxplusone added a comment.
Btw, @jhenderson and @rsmith, if you wanted to land your own files' pieces of
this patch while waiting on whoever-it-is to approve the pieces in other files,
that'd be cool. As I mentioned initially, I don't have the access necessary to
land any part of it myself.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/OcamlGCPrinter.cpp:150
+ ">= 65536.\n"
+ "(" +
+ Twine(reinterpret_cast<uintptr_t>(&FI)) + ")");
----------------
jhenderson wrote:
> Nit: I think you can fold these two string literals together. Not sure why
> they were separate before.
I think the current code is intentionally parallel to what's on line 162, so
I'd prefer to leave it alone and let whoever maintains it reflow it if they
want.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76572/new/
https://reviews.llvm.org/D76572
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
