sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:452
+ const HighlightingToken *Last = nullptr;
+ for (const HighlightingToken &Tok : Tokens) {
+ Result.emplace_back();
----------------
hokein wrote:
> note that we don't calculate the column offset for `InactiveCode` token
> (`{(line, 0), (line, 0)}`), I think we probably calculate the range with the
> new implementation, maybe add a FIXME.
Right, yes. Just skipping over them for now, with a fixme.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76663/new/
https://reviews.llvm.org/D76663
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
