baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added inline comments.
================
Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:647-653
CmdLineOption<Boolean,
"AggressiveStdFindModeling",
"Enables exploration of the failure branch in std::find-like
"
"functions.",
"false",
Released>
]>,
----------------
Szelethus wrote:
> Ah, okay, I see which one you refer to. We should totally make this non-user
> facing as well.
The option is not about state split! It is for choosing between the (default)
conservative approach and a more aggressive one. It is absolutely for the user
to set. Some users prefer less false positive for the price of losing true
positives. However, some other users prefer more true positives for the price
of additional false positives. This is why we have checker options to be able
to serve both groups.
This feature was explicitly requested by our users who first disabled iterator
checkers because of the too many false positives but later re-enabled them
because they run into a bug in a production system which could have been
prevented by enabling them. However, they run into another bug that our checker
did not find because of its conservative behavior. They requested a more
aggressive one but we must not do it for everyone. The concept of the Analyzer
is that we apply the conservative approach by default and the aggressive can be
enabled by analyzer and checker options.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77150/new/
https://reviews.llvm.org/D77150
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
