njames93 added a subscriber: jdoerfert. njames93 added a comment. In D77085#1967883 <https://reviews.llvm.org/D77085#1967883>, @nemanjai wrote:
> Awesome, thanks. Certainly fixes the compile time failures in my local build. > There is still a link-time failure (undefined reference) with my shared > libraries build: > > > tools/clang/tools/extra/clang-tidy/tool/CMakeFiles/obj.clangTidyMain.dir/ClangTidyMain.cpp.o: > In function > `clang::ast_matchers::internal::matcher_isAllowedToContainClauseKind0Matcher::matches(clang::OMPExecutableDirective > const&, clang::ast_matchers::internal::ASTMatchFinder*, > clang::ast_matchers::internal::BoundNodesTreeBuilder*) const': > > ClangTidyMain.cpp:(.text._ZNK5clang12ast_matchers8internal44matcher_isAllowedToContainClauseKind0Matcher7matchesERKNS_22OMPExecutableDirectiveEPNS1_14ASTMatchFinderEPNS1_21BoundNodesTreeBuilderE[_ZNK5clang12ast_matchers8internal44matcher_isAllowedToContainClauseKind0Matcher7matchesERKNS_22OMPExecutableDirectiveEPNS1_14ASTMatchFinderEPNS1_21BoundNodesTreeBuilderE]+0x50): > undefined reference to > `llvm::omp::isAllowedClauseForDirective(llvm::omp::Directive, > llvm::omp::Clause, unsigned int)' > collect2: error: ld returned 1 exit status > > > But that may be unrelated to this patch. That's unrelated to this patch, something about ASTMatchers and specifically OpenMP @jdoerfert has changed a few things there, may be worth hitting him up to see. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
