fhahn added a comment. This patch is quite big and I think it would be easier to review if it would be split up into distinct clang/llvm parts and maybe NEON/SVE parts on the LLVM side.
================ Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:71 + + // +sve implies +f32mm if the base architecture is v8.6A + if ((ArchKind == llvm::AArch64::ArchKind::ARMV8_6A) && Feature == "sve") ---------------- Not sure if that is the right place to handle the implication. This function just decodes a given feature string. And shouldn't that already be handled in the backend by the implications in llvm/lib/Target/AArch64/AArch64.td? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77540/new/ https://reviews.llvm.org/D77540 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
