LukeGeeson added a comment. In D77540#1969873 <https://reviews.llvm.org/D77540#1969873>, @fhahn wrote:
> This patch is quite big and I think it would be easier to review if it would > be split up into distinct clang/llvm parts and maybe NEON/SVE parts on the > LLVM side. That's a good suggestion, I shouldn't have pushed my luck! Luckily this patch doesn't introduce any new C types or IR types and so the frontend code is light, relatively speaking. That said, there is so little intrinsics work needed here that it might make sense to split the subsequent patches up to include intrinsics out-of-the-box as AArch64 asm+intrinsics, AArch32 asm+intrinsics, AArch64SVE asm + intrinsics etc... instead. Does that sound ok? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77540/new/ https://reviews.llvm.org/D77540 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
