DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.
================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2146
}
}
----------------
hubert.reinterpretcast wrote:
> Replicate the
> ```
> llvm_unreachable("Unknown linkage type!");
> ```
> here before falling off the end of a function that does not return `void`.
thanks
================
Comment at: llvm/test/CodeGen/PowerPC/aix-extern-weak.ll:45
+
+; CHECK-NOT: .weak .foo_ext_weak_ref
+; COMMON: .csect .data[RW]
----------------
hubert.reinterpretcast wrote:
> This has a prefix that is not checked by the `RUN` lines. Note also that it
> would only prevent the appearance of the subject line until the next positive
> match. Running FileCheck a second time on the same output may be necessary to
> check that it does not appear anywhere in an active manner. The passive
> method is to count on the block of `COMMON-NEXT` to exclude it.
thanks for let me know
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76932/new/
https://reviews.llvm.org/D76932
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
