amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land.
OK as is, but please consider re-using `llvm::sys::path` to distinguish separators. Please also check that there are no regressions in the clang VFS tests. ================ Comment at: clang/lib/Lex/PPDirectives.cpp:2118 + return c == '/' || (BackslashIsSeparator && c == '\\'); + }; + ---------------- Can you re-use `llvm::sys::path::is_separator` instead of inventing a new thing? You can explicitly pass `llvm::path::Style::windows` if the Microsoft extensions are enabled. Otherwise let it default to llvm::path::Style::native. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79223/new/ https://reviews.llvm.org/D79223 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits