jasonliu marked 2 inline comments as done. jasonliu added inline comments.
================ Comment at: clang/test/CodeGen/ppc32-dwarf.c:2 +// RUN: %clang_cc1 -triple powerpc-unknown-aix -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -triple powerpc-unknown-unknown -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,PPC32 +static unsigned char dwarf_reg_size_table[1024]; ---------------- Xiangling_L wrote: > Minor comment: > Would `PPC32SVR4` compared to `PPC32` make the checking content clearer since > PPC32 actually includes AIX target? Technically, it's PPC32 target except AIX (not restrict to SVR4). So PPC32SVR4 is not that accurate either. ================ Comment at: clang/test/CodeGen/ppc64-dwarf.c:2 +// RUN: %clang_cc1 -triple powerpc64-unknown-aix -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,PPC64 static unsigned char dwarf_reg_size_table[1024]; ---------------- Xiangling_L wrote: > Same comment as above. > s/PPC64/PPC64SVR4? Same above, and for PPC64 we have Darwin that's actually not SVR4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
