probinson added inline comments.

================
Comment at: clang/tools/driver/driver.cpp:391
+    if (ClangCLMode ||
+        llvm::Triple(llvm::sys::getProcessTriple()).isOSWindows())
+      Tokenizer = &llvm::cl::TokenizeWindowsCommandLine;
----------------
Testing the triple is a functional change.  I should think the test for CL mode 
is sufficient.  Note that for PS4 we run on Windows but use a GNU-compatible 
command line and response-file style.  If you want Windows-style on Windows, 
invoke the compiler as "clang-cl" instead of "clang".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80876/new/

https://reviews.llvm.org/D80876



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [P... Paul Robinson via Phabricator via cfe-commits
    • ... Sam Clegg via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
    • ... Martin Storsjö via Phabricator via cfe-commits
    • ... Martin Storsjö via Phabricator via cfe-commits
    • ... Sam Clegg via Phabricator via cfe-commits

Reply via email to