mstorsjo added a comment.

In D80876#2068428 <https://reviews.llvm.org/D80876#2068428>, @mstorsjo wrote:

> But as for keeping the old default in mingw environments, would it make sense 
> to, if on windows, check the default target triple, and if that's a mingw 
> target (`Triple.isWindowsGNUEnvironment()`), keep the unix style quoting as 
> default?


Then again... Would this defeat the purpose of this whole patch, for cases when 
building wasm e.g. in MSYS2, where the tools are built targeting mingw by 
default?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80876/new/

https://reviews.llvm.org/D80876



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [P... Sam Clegg via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Sam Clegg via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Paul Robinson via Phabricator via cfe-commits
    • ... Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
    • ... Martin Storsjö via Phabricator via cfe-commits
    • ... Martin Storsjö via Phabricator via cfe-commits
    • ... Sam Clegg via Phabricator via cfe-commits
    • ... Sam Clegg via Phabricator via cfe-commits
    • ... Martin Storsjö via Phabricator via cfe-commits
    • ... Sam Clegg via Phabricator via cfe-commits
    • ... Martin Storsjö via Phabricator via cfe-commits
    • ... Mateusz Mikuła via Phabricator via cfe-commits
    • ... Sam Clegg via Phabricator via cfe-commits
    • ... Martin Storsjö via Phabricator via cfe-commits

Reply via email to