steveire added a comment.

In D80961#2068902 <https://reviews.llvm.org/D80961#2068902>, @aaron.ballman 
wrote:

> My experience with clang-tidy has been that template instantiations are a 
> double-edged sword. The instantiation is the only place at which you have 
> sufficient information to perform many kinds of analyses, but it's also often 
> not plausible to modify the templated code because it's not clear from the 
> instantiation context how changes may impact other instantiations. The result 
> is that most of the clang-tidy checks wind up punting on template 
> instantiations similar to what they do for macros. Based on that experience, 
> I think it makes sense to continue in the proposed direction.


Great. I also think that given that the default has just been changed to 
`TK_IgnoreUnlessSpelledInSource`, we should change this soon. The facts would 
still be the same if we do this at some future date, but it would be needlessly 
more disruptive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80961/new/

https://reviews.llvm.org/D80961



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to