yaxunl marked 2 inline comments as done.
yaxunl added inline comments.

================
Comment at: clang/test/Driver/hip-phases.hip:253
+// L2-DAG: [[P0:[0-9]+]]: input, "{{.*}}obj1.o", object, (host-[[T:hip]])
+// RL2-DAG: [[P1:[0-9]+]]: clang-offload-unbundler, {[[P0]]}, object, 
(host-[[T:hip]])
+// L2-DAG: [[P2:[0-9]+]]: input, "{{.*}}obj2.o", object, (host-[[T:hip]])
----------------
yaxunl wrote:
> ashi1 wrote:
> > [[T]] is defined everytime here, should probably use [[T]] in subsequent 
> > checks?
> But those [[T]] are defined through check prefixes not used by this run line, 
> so we have to define it here.
sorry I misunderstood. Yes you are right. It only needs to be defined in the 
first line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81861/new/

https://reviews.llvm.org/D81861



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to