kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/ClangdServer.cpp:187 + Opts.ClangTidyOpts = + GetClangTidyOptions(*FSProvider.getFileSystem("."), File); Opts.SuggestMissingIncludes = SuggestMissingIncludes; ---------------- sammccall wrote: > Not sure what to do in this patch, but ultimately I don't think we > must/should pass an FS of any form into this callback. > (Doesn't make sense to assume getting options needs the FS, embedders can use > the context to know what version of the FS to use if needed) sounds good, will delete in a follow-up patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81920/new/ https://reviews.llvm.org/D81920 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits