cchen marked an inline comment as done. cchen added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8781 MappableExprsHandler::MapFlagsArrayTy &MapTypes, - CGOpenMPRuntime::TargetDataInfo &Info) { + MappableExprsHandler::MapDimArrayTy &Dims, + CGOpenMPRuntime::TargetDataInfo &Info, ---------------- ABataev wrote: > Do you really need to pass `Dims` here if you have `Dims` data member in > `Info` parameter? Why you can't use `Info.Dims` instead? I think I haven't added Dims in TargetDataInfo atm, I'll add into it and then use it via Info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits