ABataev added inline comments.
================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:16624 + if (IsPointer && !AllowAnotherPtr) + SemaRef.Diag(ELoc, diag::err_omp_section_length_undefined) << true; + else ---------------- cchen wrote: > ABataev wrote: > > Better to use integer value as selectors, not boolean. > The selector for `err_omp_section_length_undefined` is a bool value. (true > for unknown bound false for not a array type, so always be true here). > Do you mean that I need to create a new kind of diagnosis message here and > use integer as selectors? No, it is an integer, starts from `0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
