aaron.ballman added inline comments.
================ Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-faster-string-find.rst:27 + ``::std::basic_string`` and ``::std::basic_string_view`` are considered. + The list of methods to consired is fixed. ---------------- njames93 wrote: > aaron.ballman wrote: > > I'm not certain how to read that last sentence (I read it as: the list of > > methods is considered fixed and cannot be extended, which seems like a bad > > interpretation). Maybe it's talking about fix-its instead? > > > > Regardless, the typo consired -> consider should be fixed. > That typo was here before I got here, but I think it means `The list of > methods inside the classes to consider are fixed`. In other words you can't > make the check detect calls to `::MyStringClass::MyFind()`. > > Does `The list of methods inside the classes to consider are fixed.` sound > like a good replacement for the it? Oh, I understand now, thank you! The "fixed" keeps throwing me though, so I wonder if this is better still: `The check will only consider member functions named "find", "rfind", "find_first_of", "find_first_not_of", "find_last_of", or "find_last_not_of" within these classes.` or something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82720/new/ https://reviews.llvm.org/D82720 _______________________________________________ cfe-commits mailing list email@example.com https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits