nridge added inline comments.
================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:196
switch (E->getStmtClass()) {
case Stmt::CXXDependentScopeMemberExprClass: {
const auto *ME = llvm::cast<CXXDependentScopeMemberExpr>(E);
----------------
hokein wrote:
> I'm doubting whether we will miss some other exprs, since we are using it to
> find the decls for the base expr of `CXXDependentScopeMemberExpr`.
>
> could you try the following testcase (also add it to the unittest)?
>
> ```
> struct A {
> void foo() {}
> };
> struct B {
> A getA();
> };
>
> template <typename T> struct C {
> C c;
>
> void bar() { this->c.getA().foo(); }
> };
> ```
Thank you for the example! Handling this case required a bit of additional
logic, which I've now added.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82739/new/
https://reviews.llvm.org/D82739
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
