sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/SemaCXX/typo-correction.cpp:614
 
+namespace testIncludeTypeInTemplateArgument {
+template <typename T, typename U>
----------------
are these one testcase or two?
If they're independent, please use different identifiers to avoid confusion


================
Comment at: clang/test/SemaCXX/typo-correction.cpp:623
+
+  // should not reslove to a class.
+  foo(AddObservationFn, 1);    // expected-error-re {{use of undeclared 
identifier 'AddObservationFn'{{$}}}}
----------------
"resolve" and 5 lines below


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83025/new/

https://reviews.llvm.org/D83025



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to