sammccall added inline comments.
================
Comment at: clang/test/SemaCXX/typo-correction.cpp:614
+namespace testIncludeTypeInTemplateArgument {
+template <typename T, typename U>
----------------
sammccall wrote:
> are these one testcase or two?
> If they're independent, please use different identifiers to avoid confusion
I'm not sure this comment was addressed?
both testIncludeTypeInTemplateArgument and testNoCrashOnNullNNSTypoCorrection
use the name "AddObservation", which seems like something very specific but in
fact these tests are unrelated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83025/new/
https://reviews.llvm.org/D83025
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
