steakhal added a comment.

In D83660#2148834 <https://reviews.llvm.org/D83660#2148834>, @NoQ wrote:

> Looks like a copy-paste error indeed.
>
> @OikawaKirie do you accidentally have a test case to reproduce the crash, so 
> that we could add it to our regression test suite? 'Cause traditionally we 
> add a test to every patch.
>
> Note that SMT-backed constraint managers aren't an actual supported mode; 
> it's an experimental project that isn't yet supposed to be used anywhere and 
> probably won't be ever officially supported, unless reworked dramatically.


I cannot agree more. Although I would appreciate some progress improving Z3 
constraint manager. Might in the future I would spend some time on it - we will 
see.

BTW nice catch & fix @OikawaKirie!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83660/new/

https://reviews.llvm.org/D83660



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to