evandro added a comment.
Just a couple of nits, but otherwise it LGTM.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:776
}
- return "";
+ llvm_unreachable("Unknown SEW.");
}
----------------
I'd rather the first case be the `default` case and that it would call
`llvm_unreachabe()` instead.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:796
}
- return "";
+ llvm_unreachable("Unknown LMUL.");
}
----------------
Ditto.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80802/new/
https://reviews.llvm.org/D80802
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
