ianlevesque added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:817 + CurFn->getName().bytes_end()); + auto Group = crc32(FuncName) % FuncGroups; + if (Group != CGM.getCodeGenOpts().XRaySelectedFunctionGroup && ---------------- dberris wrote: > I'm a little concerned that this is randomly determined. Could we think about > using a function attribute instead that opts functions into groups by name? > Or is the intent to have "sampling" in the coverage information instead of > full coverage? The intention is to have something deterministic across builds but yeah sampled-ish across the entire codebase. By iterating over the groups with different builds we are hoping to cover every function eventually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
