kyulee added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:814 + auto FuncGroups = CGM.getCodeGenOpts().XRayTotalFunctionGroups; + if (FuncGroups > 1) { + auto FuncName = ArrayRef<uint8_t>(CurFn->getName().bytes_begin(), ---------------- MaskRay wrote: > For one group, the branch is skipped, which does not seem correct Should we check or assert `XRaySelectedFunctionGroups > 0` && `XRaySelectedFunctionGroup < XRaySelectedFunctionGroups` or the former at minimum? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits