awarzynski commandeered this revision.
awarzynski edited reviewers, added: CarolineConcatto; removed: awarzynski.
awarzynski added a comment.
Thank you for reviewing @SouraVX! I'm just about to submit an updated patch
with the requested changes.
@CarolineConcatto has recently moved to a different project and so it will be
mostly me updating this. @CarolineConcatto , thanks for all the effort!
================
Comment at: clang/include/clang/Driver/Options.td:63
+// ClangOption - This option should not be accepted by Clang.
+def NoClangOption : OptionFlag;
----------------
SouraVX wrote:
> `NoClangOption` ? Is this a Typo, or am I missing the intent behind this ?
Yup, a typo, thanks!
================
Comment at: flang/include/flang/Frontend/CompilerInstance.h:136
+ /// Add an output file onto the list of tracked output files.
+ ///
+ /// \param outFile - The output file info.
----------------
SouraVX wrote:
> NIT: Blank line ?
That's the convention for Doxygen, isn't it?
================
Comment at: flang/lib/Frontend/CompilerInstance.cpp:67
+ // Create the name of the output file
+ if (!outputPath.empty()) {
+ outFile = std::string(outputPath);
----------------
SouraVX wrote:
> Can this be simplified ? Maybe a switch case ?
Switch statement would be tricky, but I agree that this is unnecessarily
complex.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
https://reviews.llvm.org/D87989
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
