ayermolo added a comment. In D90507#2378015 <https://reviews.llvm.org/D90507#2378015>, @ikudrin wrote:
> 1. The patch needs tests to check the added functionality. > 2. DWARF64 can be generated only for a limited number of targets. There > should be diagnostics for invalid switch combinations to prevent misuse. > @MaskRay mentioned that in the patch for `llc`, D87011#2254749 > <https://reviews.llvm.org/D87011#2254749>, but that makes a lot more sense > for user-level tools. Thanks, added some checks and clang tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
