fpetrogalli marked an inline comment as done.
fpetrogalli added a comment.
Thank you for the review @sdesmalen
1. I have replied to the comment about `auto` with my reason for removing it.
2. I removed the C test, as the LL file is enough.
3. The third comment requires more investigation, I'll get back to you to see
the use of the `TypeSize` comparisons.
Thank you!
================
Comment at: llvm/lib/IR/IntrinsicInst.cpp:56
+Optional<TypeSize> DbgVariableIntrinsic::getFragmentSizeInBits() const {
+ if (Optional<DIExpression::FragmentInfo> Fragment =
+ getExpression()->getFragmentInfo())
----------------
sdesmalen wrote:
> Change back to `auto` ?
I'd like to keep this, because it seems to me the use of auto in this case
didn't fit in the cases mentioned in
https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable.
There is no direct type deduction from the context around the initialization
of the variable `Fragment`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91806/new/
https://reviews.llvm.org/D91806
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
